The following document contains the results of Checkstyle
. 
| Files | Infos  |
Warnings  |
Errors  |
|---|---|---|---|
| 143 | 0 | 0 | 3112 |
| Rules | Violations | Severity |
|---|---|---|
| PackageHtml | 17 | Error |
| NewlineAtEndOfFile | 15 | Error |
| Translation | 0 | Error |
| JavadocMethod | 104 | Error |
| JavadocType | 5 | Error |
| JavadocVariable | 19 | Error |
| JavadocStyle | 2 | Error |
| ConstantName | 10 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 2 | Error |
| MemberName | 4 | Error |
| MethodName | 4 | Error |
| PackageName | 0 | Error |
| ParameterName | 2 | Error |
| StaticVariableName | 0 | Error |
| TypeName | 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
| RedundantImport | 1 | Error |
| UnusedImports | 0 | Error |
| FileLength | 0 | Error |
| LineLength | 553 | Error |
| MethodLength | 0 | Error |
| ParameterNumber | 1 | Error |
| EmptyForIteratorPad | 0 | Error |
| MethodParamPad | 0 | Error |
| NoWhitespaceAfter | 92 | Error |
| NoWhitespaceBefore | 0 | Error |
| OperatorWrap | 0 | Error |
| ParenPad | 1 | Error |
| TypecastParenPad | 0 | Error |
| TabCharacter | 0 | Error |
| WhitespaceAfter | 56 | Error |
| WhitespaceAround | 785 | Error |
| ModifierOrder | 37 | Error |
| RedundantModifier | 17 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 2 | Error |
| LeftCurly | 125 | Error |
| NeedBraces | 34 | Error |
| RightCurly | 0 | Error |
| AvoidInlineConditionals | 25 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 0 | Error |
| EqualsHashCode | 0 | Error |
| HiddenField | 147 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 122 | Error |
| MissingSwitchDefault | 0 | Error |
| RedundantThrows | 34 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| DesignForExtension | 302 | Error |
| FinalClass | 0 | Error |
| HideUtilityClassConstructor | 5 | Error |
| InterfaceIsType | 0 | Error |
| VisibilityModifier | 9 | Error |
| ArrayTypeStyle | 0 | Error |
| FinalParameters | 392 | Error |
GenericIllegalRegexp
|
187 | Error |
| TodoComment | 1 | Error |
| UpperEll | 0 | Error |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 38 |
|
Line is longer than 80 characters. | 39 |
|
'<' is not preceded with whitespace. | 45 |
|
'<' is not followed by whitespace. | 45 |
|
'>' is not preceded with whitespace. | 45 |
|
'{' should be on the previous line. | 47 |
|
Line is longer than 80 characters. | 59 |
|
Method 'findByName' is not designed for extension - needs to be abstract, final or empty. | 61 |
|
Missing a Javadoc comment. | 61 |
|
Parameter name should be final. | 62 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 62 |
|
'<' is not preceded with whitespace. | 67 |
|
'<' is not followed by whitespace. | 67 |
|
'>' is not preceded with whitespace. | 67 |
|
Avoid inline conditionals. | 70 |
|
Line is longer than 80 characters. | 76 |
|
Method 'findGovernmentPortal' is not designed for extension - needs to be abstract, final or empty. | 78 |
|
Missing a Javadoc comment. | 78 |
|
Parameter government should be final. | 79 |
|
'<' is not preceded with whitespace. | 86 |
|
'<' is not followed by whitespace. | 86 |
|
'>' is not preceded with whitespace. | 86 |
|
Avoid inline conditionals. | 89 |
|
Line is longer than 80 characters. | 95 |
|
Method 'findNationalByCountry' is not designed for extension - needs to be abstract, final or empty. | 97 |
|
Missing a Javadoc comment. | 97 |
|
Parameter country should be final. | 98 |
|
'<' is not preceded with whitespace. | 106 |
|
'<' is not followed by whitespace. | 106 |
|
'>' is not preceded with whitespace. | 106 |
|
Avoid inline conditionals. | 109 |
|
Line is longer than 80 characters. | 115 |
|
Method 'findRegionalByRegion' is not designed for extension - needs to be abstract, final or empty. | 117 |
|
Missing a Javadoc comment. | 117 |
|
Parameter region should be final. | 118 |
|
'<' is not preceded with whitespace. | 126 |
|
'<' is not followed by whitespace. | 126 |
|
'>' is not preceded with whitespace. | 126 |
|
Avoid inline conditionals. | 129 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 23 |
|
Line is longer than 80 characters. | 24 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 26 |
|
Line is longer than 80 characters. | 27 |
|
'<' is not preceded with whitespace. | 32 |
|
'<' is not followed by whitespace. | 32 |
|
'>' is not preceded with whitespace. | 32 |
|
'{' should be on the previous line. | 33 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 44 |
| Violation | Message | Line |
|---|---|---|
|
File does not end with a newline. | 0 |
|
Line is longer than 80 characters. | 29 |
|
Line is longer than 80 characters. | 30 |
|
Utility classes should not have a public or default constructor. | 35 |
|
'{' should be on the previous line. | 36 |
| Violation | Message | Line |
|---|---|---|
|
Line has trailing spaces. | 22 |
|
Line is longer than 80 characters. | 23 |
|
Line is longer than 80 characters. | 24 |
|
'{' should be on the previous line. | 30 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 23 |
|
Line is longer than 80 characters. | 24 |
|
'{' should be on the previous line. | 30 |
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 52 |
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. | 61 |
|
Parameter name should be final. | 61 |
|
'name' hides a field. | 61 |
|
Method 'getUsername' is not designed for extension - needs to be abstract, final or empty. | 70 |
|
Method 'setUsername' is not designed for extension - needs to be abstract, final or empty. | 79 |
|
Parameter username should be final. | 79 |
|
'username' hides a field. | 79 |
|
Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. | 88 |
|
Method 'setPassword' is not designed for extension - needs to be abstract, final or empty. | 97 |
|
Parameter password should be final. | 97 |
|
'password' hides a field. | 97 |
|
Method 'getPortalId' is not designed for extension - needs to be abstract, final or empty. | 106 |
|
Method 'setPortalId' is not designed for extension - needs to be abstract, final or empty. | 115 |
|
Parameter portalId should be final. | 115 |
|
'portalId' hides a field. | 115 |
|
Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. | 124 |
|
Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. | 133 |
|
Parameter email should be final. | 133 |
|
'email' hides a field. | 133 |
| Violation | Message | Line |
|---|---|---|
|
File does not end with a newline. | 0 |
|
Line is longer than 80 characters. | 26 |
|
Line is longer than 80 characters. | 38 |
|
Line is longer than 80 characters. | 39 |
|
'<' is not preceded with whitespace. | 45 |
|
'<' is not followed by whitespace. | 45 |
|
'>' is not preceded with whitespace. | 45 |
|
'{' should be on the previous line. | 47 |
|
Line is longer than 80 characters. | 57 |
|
Line is longer than 80 characters. | 59 |
|
Method 'getDecidedResolutionsInDateOrder' is not designed for extension - needs to be abstract, final or empty. | 59 |
|
Missing a Javadoc comment. | 59 |
|
'<' is not preceded with whitespace. | 59 |
|
'<' is not followed by whitespace. | 59 |
|
'>' is not preceded with whitespace. | 59 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 59 |
|
Line is longer than 80 characters. | 62 |
|
'<' is not preceded with whitespace. | 66 |
|
'<' is not followed by whitespace. | 66 |
|
'>' is not preceded with whitespace. | 66 |
|
Line is longer than 80 characters. | 73 |
|
Method 'getVotesForPerson' is not designed for extension - needs to be abstract, final or empty. | 75 |
|
Missing a Javadoc comment. | 75 |
|
'<' is not preceded with whitespace. | 76 |
|
'<' is not followed by whitespace. | 76 |
|
'>' is not preceded with whitespace. | 76 |
|
Parameter person should be final. | 76 |
|
'<' is not preceded with whitespace. | 83 |
|
'<' is not followed by whitespace. | 83 |
|
'>' is not preceded with whitespace. | 83 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 28 |
|
Line is longer than 80 characters. | 29 |
|
'{' should be on the previous line. | 37 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 22 |
|
Line has trailing spaces. | 33 |
|
Line is longer than 80 characters. | 34 |
|
Line is longer than 80 characters. | 35 |
|
'{' should be on the previous line. | 41 |
|
'{' is followed by whitespace. | 49 |
|
'{' is followed by whitespace. | 49 |
|
'{' is followed by whitespace. | 50 |
|
'5' is a magic number. | 52 |
|
'90' is a magic number. | 60 |
|
'30' is a magic number. | 60 |
|
'90' is a magic number. | 70 |
|
'30' is a magic number. | 70 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 23 |
|
Line is longer than 80 characters. | 24 |
|
'{' should be on the previous line. | 30 |
|
Missing a Javadoc comment. | 32 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 3 |
|
'{' should be on the previous line. | 4 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 29 |
|
Line is longer than 80 characters. | 30 |
|
'{' should be on the previous line. | 38 |
|
Method 'getShortCode' is not designed for extension - needs to be abstract, final or empty. | 51 |
|
Method 'setShortCode' is not designed for extension - needs to be abstract, final or empty. | 60 |
|
Parameter shortCode should be final. | 60 |
|
'shortCode' hides a field. | 60 |
|
Method 'isOffline' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 23 |
|
Line is longer than 80 characters. | 24 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 28 |
|
Line is longer than 80 characters. | 29 |
|
'{' should be on the previous line. | 36 |
|
Method 'isNew' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 31 |
|
Line is longer than 80 characters. | 45 |
|
Line is longer than 80 characters. | 46 |
|
'{' should be on the previous line. | 52 |
|
Parameter organisation should be final. | 59 |
|
'{' is followed by whitespace. | 60 |
|
'{' is followed by whitespace. | 60 |
|
'{' is followed by whitespace. | 61 |
|
'5' is a magic number. | 63 |
|
Parameter organisation should be final. | 77 |
|
Parameter organisation should be final. | 100 |
|
'{' is followed by whitespace. | 106 |
|
'{' is followed by whitespace. | 106 |
|
'{' is followed by whitespace. | 108 |
|
'20' is a magic number. | 108 |
|
'5' is a magic number. | 110 |
|
Parameter organisation should be final. | 131 |
|
',' is not followed by whitespace. | 148 |
|
Parameter organisation should be final. | 160 |
|
'{' is followed by whitespace. | 166 |
|
'{' is followed by whitespace. | 166 |
|
'{' is followed by whitespace. | 168 |
|
'20' is a magic number. | 168 |
|
'5' is a magic number. | 170 |
|
Parameter organisation should be final. | 191 |
|
Line is longer than 80 characters. | 222 |
|
Avoid inline conditionals. | 222 |
|
Avoid inline conditionals. | 223 |
|
',' is not followed by whitespace. | 224 |
|
Parameter organisation should be final. | 239 |
|
'{' is followed by whitespace. | 245 |
|
'{' is followed by whitespace. | 245 |
|
'{' is followed by whitespace. | 247 |
|
'20' is a magic number. | 247 |
|
'5' is a magic number. | 249 |
|
Parameter organisation should be final. | 270 |
|
Parameter organisation should be final. | 310 |
|
'{' is followed by whitespace. | 316 |
|
'{' is followed by whitespace. | 316 |
|
'{' is followed by whitespace. | 318 |
|
'20' is a magic number. | 318 |
|
'5' is a magic number. | 320 |
|
Parameter organisation should be final. | 342 |
|
'<' is not preceded with whitespace. | 356 |
|
'<' is not followed by whitespace. | 356 |
|
'>' is not preceded with whitespace. | 356 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 36 |
|
Line is longer than 80 characters. | 37 |
|
Type Javadoc comment is missing an @param <ID> tag. | 42 |
|
Type Javadoc comment is missing an @param <T> tag. | 42 |
|
Line is longer than 80 characters. | 43 |
|
'<' is not preceded with whitespace. | 43 |
|
'<' is not followed by whitespace. | 43 |
|
'>' is not preceded with whitespace. | 43 |
|
'<' is not preceded with whitespace. | 44 |
|
'<' is not followed by whitespace. | 44 |
|
'>' is not preceded with whitespace. | 44 |
|
'{' should be on the previous line. | 45 |
|
'<' is not preceded with whitespace. | 48 |
|
'<' is not followed by whitespace. | 48 |
|
'>' is not preceded with whitespace. | 48 |
|
Parameter persistentClass should be final. | 55 |
|
'<' is not preceded with whitespace. | 55 |
|
'<' is not followed by whitespace. | 55 |
|
'>' is not preceded with whitespace. | 55 |
|
'persistentClass' hides a field. | 55 |
|
Line is longer than 80 characters. | 62 |
|
Method 'load' is not designed for extension - needs to be abstract, final or empty. | 64 |
|
Missing a Javadoc comment. | 64 |
|
Parameter id should be final. | 66 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 66 |
|
Line is longer than 80 characters. | 73 |
|
Method 'save' is not designed for extension - needs to be abstract, final or empty. | 75 |
|
Missing a Javadoc comment. | 75 |
|
Parameter entity should be final. | 75 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 75 |
|
Line is longer than 80 characters. | 87 |
|
Method 'delete' is not designed for extension - needs to be abstract, final or empty. | 89 |
|
Missing a Javadoc comment. | 89 |
|
Parameter entity should be final. | 89 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 89 |
|
Method 'getAll' is not designed for extension - needs to be abstract, final or empty. | 98 |
|
Missing a Javadoc comment. | 98 |
|
'<' is not preceded with whitespace. | 100 |
|
'<' is not followed by whitespace. | 100 |
|
'>' is not preceded with whitespace. | 100 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 100 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 23 |
|
Line is longer than 80 characters. | 30 |
|
Line is longer than 80 characters. | 31 |
|
'<' is not preceded with whitespace. | 36 |
|
'<' is not followed by whitespace. | 36 |
|
'>' is not preceded with whitespace. | 36 |
|
'{' should be on the previous line. | 37 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 48 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 59 |
|
Redundant 'public' modifier. | 68 |
|
'<' is not preceded with whitespace. | 68 |
|
'<' is not followed by whitespace. | 68 |
|
'>' is not preceded with whitespace. | 68 |
|
Redundant throws: 'DataAccessException' is unchecked exception. | 68 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 29 |
|
Line is longer than 80 characters. | 30 |
|
'{' should be on the previous line. | 38 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 80 characters. | 21 |
|
Line is longer than 80 characters. | 34 |
|
Line is longer than 80 characters. | 35 |
|
'{' should be on the previous line. | 41 |
|
Variable 'loginActionListener' must be private and have accessor methods. | 53 |
|
Parameter ev should be final. | 54 |
|
Variable 'cancelActionListener' must be private and have accessor methods. | 61 |
|
Parameter ev should be final. | 62 |
|
'200' is a magic number. | 74 |
|
'200' is a magic number. | 74 |
|
'350' is a magic number. | 75 |
|
'160' is a magic number. | 75 |
|
'{' is followed by whitespace. | 76 |
|
'{' is followed by whitespace. | 76 |
|
'120' is a magic number. | 76 |
|
'200' is a magic number. | 76 |
|
'{' is followed by whitespace. | 78 |
|
'30' is a magic number. | 78 |
|
'30' is a magic number. | 78 |
|
'30' is a magic number. | 78 |
|
'30' is a magic number. | 78 |
|
'10' is a magic number. | 79 |
|
'5' is a magic number. | 80 |
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 121 |
|
Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. | 130 |